Script Panel Refactoring
- 1 Resources
- 2 Goals
- 3 Related Issues
- 4 Related Mozilla Issues
- 5 JSD2 API Requirements
- 6 Current Debugger Architecture
- 7 New Debugger Architecture
- HTTP Monitor
- Firebug 1.7 BTI
- Net Panel Architecture Review
- Remoting Prototype
- Remoting Architecture
- JSD2 Adoption
- Debugger Client API
- JS Debugger API Guide
- JS Debugger API Reference
- DevTools Debugger
- Remote Debugging Protocol
- Adopt JSD2 (get rid of all JSD1 APIs)
- Support remote debugging
Related Mozilla Issues
- Meta bug: Implement a script Debugger
- bug 740825: Implement conditional breakpoints
- bug 816756: CodeMirror as an alternative to Orion
JSD2 API Requirements
The following list summarizes the high-level features that Firebug needs to support. It should be verified that all the features can be re-implemented on top of JSD2 before starting the refactoring.
- List of scripts available on selected tab (including static, events and evaluated scripts) including iframes →
- Stepping (into, over, out, resume, current line)
- Support for
- Support for breakpoints (add, remove, enable, disabled, conditional, list of existing breakpoints) →
- Recognize executable lines
- Dynamic eval in a frame (used e.g. by the Watch Side Panel when the debugger is halted) →
- Get stack frames (including passed arguments) →
- Scope chain variable exploring (with & closure scopes). It should be possible to see all values. →
- Break on next call
- Profiling (was part of JSD1)
- Tracking (break on) throw/catch/error →
- Tracking (monitoring) function calls
- Freezing page UI if debugger is halted (including timeouts, intervals and worker threads)
Not Ready in JSD2
- There is not source for evals.
- new Function scripts?
- As soon as this one is fixed
- Profiling is unrelated to JSD2. What is the plan here?
- Tracking (break on) throw/catch/error; also what is the plan?
Current Debugger Architecture
This section describes the current debugger architecture.
There are several layers/objects, so let's describe them step by step starting from the bottom.
- Backend: JSD1, FirebugService, Debugger
This layer represents the JSD1 platform API. This API allows to implement script debuggers and represents a direct competition to the JSD2 API. Of course this layer should entirely disappear and should be replaced by JSD2.
Firebug.Debugger module) and fires various events to them (e.g.
onToggleMonitor, etc.) or execute their callback methods (e.g.
- Activate/deactivate JSD in the browser. The activation is global for all current browser windows.
- Hook debugger events (interrupts, break on a breakpoint, etc.)
- Maintains a list of registered debuggers (there is usually just one - Firebug debugger) and sends events to them.
- Manages the nested event loop that is created for the debugger UI when a page's JS execution breaks.
- Sets/removes/enables/disables/saves/loads breakpoints
- Implements debugger stepping over/in/out/runUntil
- Monitors function calls
- Starts/stops profiling
- Tracks exceptions and errors (not working well)
- Tracks compiled scripts (not all of them)
This object is derived from
Firebug.Module and represents Firebug's debugger. It's also registered as a debugger into the Firebug Service (FBS). This object should be the only one accessing FBS. It calls FBS API and receives various callbacks and events.
This object implements methods that can be used by the Script Panel or other parts of Firebug (e.g. by those panels which implements [[Script Panel#Break On Next|BON]).
Some examples of the API:
The implementation of these methods is based on FBS API.
There is also
Firebug.DebuggerListener that defines the interface used by FBS
onScriptCreated(there are more
Firebug.Debugger and the
ScriptPanel. The current implementation is in-process only, so based on direct
Firebug.Debugger API calls.
API of the tool is as follows:
The BTI is used by Crossfire. Crossfire has the following structure:
Crossfire Panel ↓ Crossfire Module ↓ Crossfire Server ↓ Crossfire Socket Transport
When starting up it does the following.
- Register tools (e.g. console, inspector, ...)
- Start server
- Create socket transport
- Add BTI listener
- Set connection status
The Script Panel sits at the top of the whole stack of layers/objects. It represents the debugger UI (a view + a controller). The implementation of this object is quite extensive since it also includes the source code view and viewport (see
The Script panel should never accesses the
Firebug.Debugger directly. It should always use the
So, for example, if the user clicks on the Breakpoint Column, the action is handled by the Script panel, forwarded to the
Firebug.Debugger, which forwards it to
FBS is using JSD1 API to set the breakpoint.
The synchronization happens through basic Firebug mechanisms like
New Debugger Architecture
The Script panel needs to be built on top of JSD2, the Remote Debugging Protocol (RDP) and Firebug remoting API. Remoting is already supported by the HTTP Monitor.
First of all take a look a the following diagram:
- DebuggerClient This object comes from the Firefox platform and is responsible for the connection to the server back-end. The object maintains the underlying transport layer, it's responsible for tab attaching/detaching, it implements basic packets send and receive logic. The implementation is currently within resource://gre/modules/devtools/dbg-client.jsm module.
- DebuggerClientModule This module (singleton, one per Firebug instance) represents a wrapper around DebuggerClient. It implements the connection setup and initialization (e.g. port number). This object represents the connection in Firebug and should be shared by all remotable tools (e.g. the Script panel, Net panel, Profiler, etc.). The name of this module probably isn't descriptive enough, so it could be changed. This object (or a related object) could also replace the TabWatcher.
- DebuggerTool This object implements an API related to debugging (typical methods:
setBreakpoint, etc.). The Script panel should always consume the debugger API through this object. DebuggerTool registers itself as a DebuggerClientModule and thus gets all necessary events from the back-end (e.g.
- ScriptPanel Represents the debugger UI and listens mostly to
onStopDebuggingevents. Those are used to properly update the panel's UI.
- ScriptView The main responsibility of this object is displaying the source code (using color syntax highlight). This object is based on CodeMirror.
- ThreadClient This object comes from the Firefox platform and is responsible for tab-thread related logic.
- CallstackPanel This panel displays the list of function call stack frames when the debugger is halted. The frames list is synchronized with the stack frame cache of the ThreadClient using
- WatchPanel This panel displays the list of watch expresssions plus the available DOM properties of the current stack frame when the debugger is halted.
- BreakpointStore The responsibility of this object is the breakpoint persistence across Firefox restarts (in breakpoint.json file).
- BreakpointPanel This panel displays the list of set breakpoints.
A grip represents a handle to a server side object (see RDP for more details).
The Firebug framework introduces several objects that deal with these handles. See the next diagram:
- ClientFactory This is the place where grips instances are created. Every grip object is associated with a class (see RDP) and uses Firebug.registerGrip to register itself. This factory uses a list of registered types and instantiates the right one according to the server-side grip class attribute.
- ClientCache The cache is the place where panels and other parts of Firebug should ask for grip-objects. If the requested object is not in the cache, a request is sent to the back-end and a promise synchronously returned and asynchronously resolved. If the object is already in the cache, a promise is returned and synchronously resolved. ClientCache is the only place, which uses ClientFactory. See more about asynchronous data access.
- ObjectClient Represents a wrapper for the RDP Grip
- Property Represents a wrapper for the RDP Property
- FunctionGrip Represents a wrapper for a function object.
- ScopeClient Represents a wrapper for a scope object. This object is used by the Watch side panel to show a chain of the current scopes.
This section describes the architecture design for debugger breakpoints.
- BreakpointStore The main component implementing a public API for breakpoint creation and removal. This object is also responsible for client-side persistence and initialization. There is one instance of this object per browser window (i.e. per Firebug). So, if a breakpoint is created in one context, it automatically appears in all contexts that are using the same URL.
- FunctionMonitor, ScriptPanel, BreakpointPanel, ConsolePanel These represent example objects that are dealing with breakpoints. There can be even more such objects in the future. All these objects use the API implemented by the BreakpointStore object. These objects also register themselves as DebuggerTool listeners to be notified about breakpoint related changes.
- DebuggerTool is responsible for breakpoint creation/removal on the server side. DebuggerTool registers itself as BreakpointStore listener to be notified about breakpoint creation/removal and sync the server side (i.e. create or remove breakpoints on the server side). There is one instance of this object per context.
See an example of a breakpoint creation (using the Script panel UI):
- The user clicks on the ScriptView breakpoint column. It's currently based on CodeMirror (previously it was based on Orion).
- ScriptView notifies the ScriptPanel about the action.
- ScriptPanel is using the BreakpointStore API to create a breakpoint. It calls
addBreakpoint. Breakpoint creation is asynchronous, since the server side needs to be notified through TCP/IP. UI objects (e.g. panels) should wait for the
onBreakpointAddedevent to update themselves.
- BreakpointStore sends an
onAddBreakpointevent to all registered listeners. These listeners are mostly all DebuggerTool instances (one per context) and also all UI objects that want to display a temporary "waiting" icon at the place where the breakpoint will (asynchronously) appear.
- DebuggerTool uses its associated ThreadClient to create a breakpoint on the server side. Each DebuggerTool instance will do this for its context. This way all contexts will be updated.
- ThreadClient sends a packet to the server side and waits for the asynchronous response.
- DebuggerTool has a direct (function) callback that is executed as soon as the response comes back from the server. The breakpoint's location is auto-corrected at this point if needed, in case it is set at a line that doesn't contain executable code.
- DebuggerTool notifies all registered listeners (usually panels coming from the same context) about the added breakpoint. It sends an
onBreakpointAddedevent to the ScriptPanel in this scenario.
- ScriptPanel calls
updateBreakpoint, so the ScriptView can update itself, i.e. remove the "waiting" icon and display the new breakpoint at the right location. It might also scroll to make sure that auto-corrected location is visible to the user.
Breakpoint Condition Editor
Let's yet see a sequence of actions describing what happens if the BreakpointConditionEditor is opened at a line with no breakpoint. In such case a breakpoint needs to be automatically created and used if the user actually creates a condition.
- onGutterClick The user right clicks on the breakpoint column
- startBreakpointConditionEditor An event is sent to the ScriptPanel. Note that the ScriptView communicates with the ScriptPanel only through events.
- A helper initializeBreakpointConditionEditor is executed. This method creates a temporary BP structure with the condition set to an empty string.
- The initializeBreakpoint method is called to display the breakpoint "waiting" icon. The temporary BP is passed into it.
- The ScriptView sends an
addBreakpointevent back to the ScriptPanel. This event is faked and mimicking a click on the breakpoint column.
- The ScriptPanel uses the BreakpointStore to add a breakpoint just like it always does if the user clicks on the breakpoint column to create (or remove) a breakpoint, but it passes the condition to it, so the breakpoint is not stored immediately (kind of a hack).
- The BreakpointStore sends an
onAddBreakpointevent to all listeners, i.e. to all DebuggerTool instances.
- The DebuggerTool sets the breakpoint on the server side. We need to do this before displaying the BreakpointConditionEditor, because we need to know the correct line. Note that the user could have clicked on a non-executable line.
onBreakpointAddedevent is sent from the DebuggerTool to the ScriptPanel and the condition editor can be finally displayed to the user by calling
Note: The entire feature is currently wired to the current breakpoint architecture. It should be rather implemented as an independent module.